CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-11-06 11:18:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

[Mod] Fix recording username changes (#2919)

Browse Source 
* fix(mod): past names are now properly recorded in `on_user_update` event

* chore(changelog): add towncrier entry

* chore(changelog): specify what commands were affected
This commit is contained in:
jack1142 2019-08-27 18:42:56 +02:00 committed by Michael H
parent bbd30411fd
commit fb9fec282b
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/mod/2918.bugfix.rst Normal file
View File

@ -0,0 +1 @@
Fixed Mod cog not recording username changes for ``[p]names`` and ``[p]userinfo`` commands

4
redbot/cogs/mod/events.py
View File

@ -95,7 +95,7 @@ class Events(MixinMeta):
await self.check_mention_spam(message) await self.check_mention_spam(message)
@commands.Cog.listener() @commands.Cog.listener()
async def on_member_update(self, before: discord.Member, after: discord.Member): async def on_user_update(self, before: discord.User, after: discord.User):
if before.name != after.name: if before.name != after.name:
async with self.settings.user(before).past_names() as name_list: async with self.settings.user(before).past_names() as name_list:
while None in name_list: # clean out null entries from a bug while None in name_list: # clean out null entries from a bug
@ -107,6 +107,8 @@ class Events(MixinMeta):
while len(name_list) > 20: while len(name_list) > 20:
name_list.pop(0) name_list.pop(0)
@commands.Cog.listener()
async def on_member_update(self, before: discord.Member, after: discord.Member):
if before.nick != after.nick and after.nick is not None: if before.nick != after.nick and after.nick is not None:
async with self.settings.member(before).past_nicks() as nick_list: async with self.settings.member(before).past_nicks() as nick_list:
while None in nick_list: # clean out null entries from a bug while None in nick_list: # clean out null entries from a bug