From fb9fec282b093bd8dd8a1350160a2a8e93942f16 Mon Sep 17 00:00:00 2001
From: jack1142 <6032823+jack1142@users.noreply.github.com>
Date: Tue, 27 Aug 2019 18:42:56 +0200
Subject: [PATCH] [Mod] Fix recording username changes (#2919)

* fix(mod): past names are now properly recorded in `on_user_update` event

* chore(changelog): add towncrier entry

* chore(changelog): specify what commands were affected
---
 changelog.d/mod/2918.bugfix.rst | 1 +
 redbot/cogs/mod/events.py       | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)
 create mode 100644 changelog.d/mod/2918.bugfix.rst

diff --git a/changelog.d/mod/2918.bugfix.rst b/changelog.d/mod/2918.bugfix.rst
new file mode 100644
index 000000000..cafa96097
--- /dev/null
+++ b/changelog.d/mod/2918.bugfix.rst
@@ -0,0 +1 @@
+Fixed Mod cog not recording username changes for ``[p]names`` and ``[p]userinfo`` commands
\ No newline at end of file
diff --git a/redbot/cogs/mod/events.py b/redbot/cogs/mod/events.py
index b83dddebb..d63a6c74f 100644
--- a/redbot/cogs/mod/events.py
+++ b/redbot/cogs/mod/events.py
@@ -95,7 +95,7 @@ class Events(MixinMeta):
             await self.check_mention_spam(message)
 
     @commands.Cog.listener()
-    async def on_member_update(self, before: discord.Member, after: discord.Member):
+    async def on_user_update(self, before: discord.User, after: discord.User):
         if before.name != after.name:
             async with self.settings.user(before).past_names() as name_list:
                 while None in name_list:  # clean out null entries from a bug
@@ -107,6 +107,8 @@ class Events(MixinMeta):
                 while len(name_list) > 20:
                     name_list.pop(0)
 
+    @commands.Cog.listener()
+    async def on_member_update(self, before: discord.Member, after: discord.Member):
         if before.nick != after.nick and after.nick is not None:
             async with self.settings.member(before).past_nicks() as nick_list:
                 while None in nick_list:  # clean out null entries from a bug