From 27e7a3e86e7b829270226c690400501b13cafcde Mon Sep 17 00:00:00 2001
From: sickprodigy <prodigysick@gmail.com>
Date: Sun, 16 Nov 2025 13:54:26 -0500
Subject: [PATCH] Refactor control_html class implementation for better
 readability and maintainability

---
 Upload/inc/plugins/htmlposts.php | 68 +++++++++++++++-----------------
 1 file changed, 31 insertions(+), 37 deletions(-)

diff --git a/Upload/inc/plugins/htmlposts.php b/Upload/inc/plugins/htmlposts.php
index 714e5bd..1608df8 100644
--- a/Upload/inc/plugins/htmlposts.php
+++ b/Upload/inc/plugins/htmlposts.php
@@ -146,6 +146,37 @@ function htmlposts_check_permissions($groups_comma, $user)
 		return true;
 }
 
+if (!class_exists("control_html"))
+{
+    class control_html
+    {
+        public $html_enabled;
+
+        function __construct()
+        {
+            global $parser;
+            $this->html_enabled = $parser->options['allow_html'];
+        }
+
+        function set_html($status)
+        {
+            $status = (int)$status;
+            if ($status != 0 && $status != 1) return false;
+
+            if ($status == 0 && $this->html_enabled == 1)
+                return false;
+
+            global $parser;
+            $parser->options['allow_html'] = $status;
+            global $parser_options;
+            if (!empty($parser_options))
+                $parser_options['allow_html'] = $status;
+
+            return true;
+        }
+    }
+}
+
 function htmlposts_parse(&$message)
 {
 	global $mybb, $db;
@@ -201,43 +232,6 @@ function htmlposts_parse(&$message)
 		return; // unfortunately we cannot proceed without a $parser object created
 	}
 
-	// Create a new class to control the parser options easily
-    if (!class_exists("control_html"))
-    {
-        class control_html
-        {
-            public $html_enabled;
-    
-            function __construct()
-            {
-                // Is it enabled already? Save it in a var to later disallow disabling
-                global $parser;
-                $this->html_enabled = $parser->options['allow_html'];
-            }
-    
-            function set_html($status)
-            {
-                $status = (int)$status;
-                if ($status != 0 && $status != 1) return false;
-    
-                // if we're trying to disable it but it's enabled by default, disallow the action
-                if ($status == 0 && $this->html_enabled == 1)
-                    return false;
-    
-                global $parser;
-    
-                // Set to desired status
-                $parser->options['allow_html'] = $status;
-                // for previewing posts
-                global $parser_options;
-                if (!empty($parser_options))
-                    $parser_options['allow_html'] = $status;
-    
-                return true;
-            }
-        }
-    }
-
 	// Create object if it doesn't exist
 	if (!is_object($control_html))
 		$control_html = new control_html();