From b2729d16aa6df2d24f04012140852319b03e47c2 Mon Sep 17 00:00:00 2001 From: Yiannis Christodoulou Date: Sat, 18 Oct 2025 21:43:24 +0300 Subject: [PATCH] Hide settings tooltip when menu is open Removes the tooltip from the settings button when the settings menu is open and restores it when the menu is closed. This improves user experience by preventing the tooltip from overlapping the open menu. --- .../src/components/controls/CustomSettingsMenu.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/frontend-tools/video-js/src/components/controls/CustomSettingsMenu.js b/frontend-tools/video-js/src/components/controls/CustomSettingsMenu.js index c1689d1c..56f69c0d 100644 --- a/frontend-tools/video-js/src/components/controls/CustomSettingsMenu.js +++ b/frontend-tools/video-js/src/components/controls/CustomSettingsMenu.js @@ -990,8 +990,12 @@ class CustomSettingsMenu extends Component { if (btnEl) { if (!isVisible) { btnEl.classList.add('settings-clicked'); + // Hide tooltip when menu is open + btnEl.removeAttribute('title'); } else { btnEl.classList.remove('settings-clicked'); + // Restore tooltip when menu is closed + btnEl.setAttribute('title', 'Settings'); } } } @@ -1011,10 +1015,12 @@ class CustomSettingsMenu extends Component { this.refreshSubtitlesSubmenu(); } - // Mark settings button as active + // Mark settings button as active and hide tooltip const btnEl = this.settingsButton?.el(); if (btnEl) { btnEl.classList.add('settings-clicked'); + // Hide tooltip when menu is open + btnEl.removeAttribute('title'); } } @@ -1032,10 +1038,12 @@ class CustomSettingsMenu extends Component { if (this.qualitySubmenu) this.qualitySubmenu.style.display = 'none'; if (this.subtitlesSubmenu) this.subtitlesSubmenu.style.display = 'none'; - // Remove active state from settings button + // Remove active state from settings button and restore tooltip const btnEl = this.settingsButton?.el(); if (btnEl) { btnEl.classList.remove('settings-clicked'); + // Restore tooltip when menu is closed + btnEl.setAttribute('title', 'Settings'); } // Restore body scroll on mobile when closing