CopyBot/mediacms
1
0
Fork 0
mirror of https://github.com/mediacms-io/mediacms.git synced 2025-11-06 07:28:53 -05:00
Code Issues Packages Projects Releases Wiki Activity

Comment out stopPropagation in settings menu events

Browse Source 
Replaces all e.stopPropagation() calls with comments in CustomSettingsMenu.js. This change allows event propagation for touch and click events, potentially improving compatibility with other UI components or event handlers.
This commit is contained in:
Yiannis Christodoulou 2025-10-20 00:22:22 +03:00
parent 567bb18e91
commit 61bfa67e42
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
frontend-tools/video-js/src/components/controls/CustomSettingsMenu.js
View File

@ -213,7 +213,7 @@ class CustomSettingsMenu extends Component {
// Only trigger if it's a tap (not a swipe) // Only trigger if it's a tap (not a swipe)
if (distance < 50) { if (distance < 50) {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); // e.stopPropagation();
touchHandled = true; touchHandled = true;
this.toggleSettings(e); this.toggleSettings(e);
} }
@ -227,7 +227,7 @@ class CustomSettingsMenu extends Component {
// Only handle click if touch wasn't already handled // Only handle click if touch wasn't already handled
if (!touchHandled) { if (!touchHandled) {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); // e.stopPropagation();
this.toggleSettings(e); this.toggleSettings(e);
} }
touchHandled = false; // Reset for next interaction touchHandled = false; // Reset for next interaction
@ -347,7 +347,7 @@ class CustomSettingsMenu extends Component {
this.settingsOverlay.addEventListener( this.settingsOverlay.addEventListener(
'touchstart', 'touchstart',
(e) => { (e) => {
e.stopPropagation(); // e.stopPropagation();
}, },
{ passive: true } { passive: true }
); );
@ -656,7 +656,7 @@ class CustomSettingsMenu extends Component {
const closeButton = this.settingsOverlay.querySelector('.settings-close-btn'); const closeButton = this.settingsOverlay.querySelector('.settings-close-btn');
if (closeButton) { if (closeButton) {
const closeFunction = (e) => { const closeFunction = (e) => {
e.stopPropagation(); // e.stopPropagation();
this.settingsOverlay.classList.remove('show'); this.settingsOverlay.classList.remove('show');
this.settingsOverlay.style.display = 'none'; this.settingsOverlay.style.display = 'none';
this.speedSubmenu.style.display = 'none'; this.speedSubmenu.style.display = 'none';
@ -681,7 +681,7 @@ class CustomSettingsMenu extends Component {
// Settings item clicks // Settings item clicks
this.settingsOverlay.addEventListener('click', (e) => { this.settingsOverlay.addEventListener('click', (e) => {
e.stopPropagation(); // e.stopPropagation();
if (e.target.closest('[data-setting="playback-speed"]')) { if (e.target.closest('[data-setting="playback-speed"]')) {
this.speedSubmenu.style.display = 'flex'; this.speedSubmenu.style.display = 'flex';
@ -722,7 +722,7 @@ class CustomSettingsMenu extends Component {
this.settingsOverlay.addEventListener( this.settingsOverlay.addEventListener(
'touchend', 'touchend',
(e) => { (e) => {
e.stopPropagation(); // e.stopPropagation();
if (this.isTouchScrolling) { if (this.isTouchScrolling) {
this.isTouchScrolling = false; this.isTouchScrolling = false;
return; return;
@ -760,7 +760,7 @@ class CustomSettingsMenu extends Component {
'touchend', 'touchend',
(e) => { (e) => {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); // e.stopPropagation();
this.speedSubmenu.style.display = 'none'; this.speedSubmenu.style.display = 'none';
}, },
{ passive: false } { passive: false }
@ -775,7 +775,7 @@ class CustomSettingsMenu extends Component {
'touchend', 'touchend',
(e) => { (e) => {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); // e.stopPropagation();
this.qualitySubmenu.style.display = 'none'; this.qualitySubmenu.style.display = 'none';
}, },
{ passive: false } { passive: false }
@ -790,7 +790,7 @@ class CustomSettingsMenu extends Component {
'touchend', 'touchend',
(e) => { (e) => {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); // e.stopPropagation();
this.subtitlesSubmenu.style.display = 'none'; this.subtitlesSubmenu.style.display = 'none';
}, },
{ passive: false } { passive: false }
@ -826,7 +826,7 @@ class CustomSettingsMenu extends Component {
this.speedSubmenu.addEventListener( this.speedSubmenu.addEventListener(
'touchend', 'touchend',
(e) => { (e) => {
e.stopPropagation(); // e.stopPropagation();
if (this.isTouchScrolling) { if (this.isTouchScrolling) {
this.isTouchScrolling = false; this.isTouchScrolling = false;
return; return;
@ -870,7 +870,7 @@ class CustomSettingsMenu extends Component {
this.qualitySubmenu.addEventListener( this.qualitySubmenu.addEventListener(
'touchend', 'touchend',
(e) => { (e) => {
e.stopPropagation(); // e.stopPropagation();
if (this.isTouchScrolling) { if (this.isTouchScrolling) {
this.isTouchScrolling = false; this.isTouchScrolling = false;
return; return;
@ -915,7 +915,7 @@ class CustomSettingsMenu extends Component {
this.subtitlesSubmenu.addEventListener( this.subtitlesSubmenu.addEventListener(
'touchend', 'touchend',
(e) => { (e) => {
e.stopPropagation(); // e.stopPropagation();
if (this.isTouchScrolling) { if (this.isTouchScrolling) {
this.isTouchScrolling = false; this.isTouchScrolling = false;
return; return;
@ -953,7 +953,7 @@ class CustomSettingsMenu extends Component {
} }
toggleSettings(e) { toggleSettings(e) {
e.stopPropagation(); // e.stopPropagation();
const isVisible = this.settingsOverlay.classList.contains('show'); const isVisible = this.settingsOverlay.classList.contains('show');
if (isVisible) { if (isVisible) {