CopyBot/mediacms
1
0
Fork 0
mirror of https://github.com/mediacms-io/mediacms.git synced 2025-11-10 17:38:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: First chapter is not saved, if not given a name, although indicating it is saved (151)

Browse Source
This commit is contained in:
Yiannis Christodoulou 2025-11-09 22:42:14 +02:00
parent 846d9fa3f6
commit 5190fb4474
1 changed files with 37 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
frontend-tools/chapters-editor/client/src/components/TimelineControls.tsx
View File

@ -26,6 +26,18 @@ const mediaPageLinkStyles = {
}, },
} as const; } as const;
// Helper function to parse time string (HH:MM:SS.mmm) to seconds
const parseTimeToSeconds = (timeString: string): number => {
const parts = timeString.split(':');
if (parts.length !== 3) return 0;
const hours = parseInt(parts[0], 10) || 0;
const minutes = parseInt(parts[1], 10) || 0;
const seconds = parseFloat(parts[2]) || 0;
return hours * 3600 + minutes * 60 + seconds;
};
interface TimelineControlsProps { interface TimelineControlsProps {
currentTime: number; currentTime: number;
duration: number; duration: number;
@ -191,7 +203,17 @@ const TimelineControls = ({
setIsAutoSaving(true); setIsAutoSaving(true);
// Format segments data for API request - use ref to get latest segments and sort by start time // Format segments data for API request - use ref to get latest segments and sort by start time
// ONLY save chapters that have custom titles - filter out chapters without titles or with default names
const chapters = clipSegmentsRef.current const chapters = clipSegmentsRef.current
.filter((segment) => {
// Filter out empty titles
if (!segment.chapterTitle || !segment.chapterTitle.trim()) {
return false;
}
// Filter out default chapter names like "Chapter 1", "Chapter 2", etc.
const isDefaultName = /^Chapter \d+$/.test(segment.chapterTitle);
return !isDefaultName;
})
.sort((a, b) => a.startTime - b.startTime) // Sort by start time chronologically .sort((a, b) => a.startTime - b.startTime) // Sort by start time chronologically
.map((chapter) => ({ .map((chapter) => ({
startTime: formatDetailedTime(chapter.startTime), startTime: formatDetailedTime(chapter.startTime),
@ -199,7 +221,7 @@ const TimelineControls = ({
chapterTitle: chapter.chapterTitle, chapterTitle: chapter.chapterTitle,
})); }));
logger.debug('chapters', chapters); logger.debug('Filtered chapters (only custom titles):', chapters);
const mediaId = (typeof window !== 'undefined' && (window as any).MEDIA_DATA?.mediaId) || null; const mediaId = (typeof window !== 'undefined' && (window as any).MEDIA_DATA?.mediaId) || null;
// For testing, use '1234' if no mediaId is available // For testing, use '1234' if no mediaId is available
@ -207,12 +229,13 @@ const TimelineControls = ({
logger.debug('mediaId', finalMediaId); logger.debug('mediaId', finalMediaId);
if (!finalMediaId || chapters.length === 0) { if (!finalMediaId) {
logger.debug('No mediaId or segments, skipping auto-save'); logger.debug('No mediaId, skipping auto-save');
setIsAutoSaving(false); setIsAutoSaving(false);
return; return;
} }
// Save chapters (empty array if no chapters have titles)
logger.debug('Auto-saving segments:', { mediaId: finalMediaId, chapters }); logger.debug('Auto-saving segments:', { mediaId: finalMediaId, chapters });
const response = await autoSaveVideo(finalMediaId, { chapters }); const response = await autoSaveVideo(finalMediaId, { chapters });
@ -499,11 +522,20 @@ const TimelineControls = ({
try { try {
// Format chapters data for API request - sort by start time first // Format chapters data for API request - sort by start time first
// ONLY save chapters that have custom titles - filter out chapters without titles or with default names
const chapters = clipSegments const chapters = clipSegments
.filter((segment) => segment.chapterTitle && segment.chapterTitle.trim()) .filter((segment) => {
// Filter out empty titles
if (!segment.chapterTitle || !segment.chapterTitle.trim()) {
return false;
}
// Filter out default chapter names like "Chapter 1", "Chapter 2", etc.
const isDefaultName = /^Chapter \d+$/.test(segment.chapterTitle);
return !isDefaultName;
})
.sort((a, b) => a.startTime - b.startTime) // Sort by start time chronologically .sort((a, b) => a.startTime - b.startTime) // Sort by start time chronologically
.map((segment) => ({ .map((segment) => ({
chapterTitle: segment.chapterTitle || `Chapter ${segment.id}`, chapterTitle: segment.chapterTitle,
from: formatDetailedTime(segment.startTime), from: formatDetailedTime(segment.startTime),
to: formatDetailedTime(segment.endTime), to: formatDetailedTime(segment.endTime),
})); }));