From fba2fbc134c9d2c10b52d8ac3229385634d32501 Mon Sep 17 00:00:00 2001
From: lucas-neynar <lucas@neynar.com>
Date: Mon, 17 Mar 2025 13:27:04 -0700
Subject: [PATCH] feat: check for port in use and add instructions on fixing

---
 package.json   |  2 +-
 scripts/dev.js | 57 +++++++++++++++++++++++++++++++++++++++++---------
 2 files changed, 48 insertions(+), 11 deletions(-)

diff --git a/package.json b/package.json
index c8b0acb..1c59491 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "create-neynar-farcaster-frame",
-  "version": "1.0.7",
+  "version": "1.0.8",
   "type": "module",
   "files": [
     "bin/index.js"
diff --git a/scripts/dev.js b/scripts/dev.js
index bf6ae39..2a91ade 100755
--- a/scripts/dev.js
+++ b/scripts/dev.js
@@ -6,6 +6,19 @@ let nextDev;
 let isCleaningUp = false;
 
 async function startDev() {
+  // Check if port 3000 is already in use
+  const isPortInUse = await checkPort(3000);
+  if (isPortInUse) {
+    console.error('Port 3000 is already in use. To find and kill the process using this port:\n\n' +
+      '1. On macOS/Linux, run: lsof -i :3000\n' +
+      '   On Windows, run: netstat -ano | findstr :3000\n\n' +
+      '2. Note the PID (Process ID) from the output\n\n' + 
+      '3. On macOS/Linux, run: kill -9 <PID>\n' +
+      '   On Windows, run: taskkill /PID <PID> /F\n\n' +
+      'Then try running this command again.');
+    process.exit(1);
+  }
+
   // Start localtunnel and get URL
   tunnel = await localtunnel({ port: 3000 });
   let ip;
@@ -53,28 +66,52 @@ async function startDev() {
 
     try {
       if (nextDev) {
-        // Kill the main process first
-        nextDev.kill('SIGKILL');
-        // Then kill any remaining child processes in the group
-        if (nextDev?.pid) {
-          process.kill(-nextDev.pid);
+        try {
+          // Kill the main process first
+          nextDev.kill('SIGKILL');
+          // Then kill any remaining child processes in the group
+          if (nextDev?.pid) {
+            try {
+              process.kill(-nextDev.pid);
+            } catch (e) {
+              // Ignore ESRCH errors when killing process group
+              if (e.code !== 'ESRCH') throw e;
+            }
+          }
+          console.log('🛑 Next.js dev server stopped');
+        } catch (e) {
+          // Ignore errors when killing nextDev
+          console.log('Note: Next.js process already terminated');
         }
-        console.log('🛑 Next.js dev server stopped');
       }
       
       if (tunnel) {
-        await tunnel.close();
-        console.log('🌐 Tunnel closed');
+        try {
+          await tunnel.close();
+          console.log('🌐 Tunnel closed');
+        } catch (e) {
+          console.log('Note: Tunnel already closed');
+        }
       }
 
       // Force kill any remaining processes on port 3000
       try {
         if (process.platform === 'darwin') { // macOS
-          await spawn('lsof', ['-ti', ':3000']).stdout.on('data', (data) => {
+          const lsof = spawn('lsof', ['-ti', ':3000']);
+          lsof.stdout.on('data', (data) => {
             data.toString().split('\n').forEach(pid => {
-              if (pid) process.kill(parseInt(pid), 'SIGKILL');
+              if (pid) {
+                try {
+                  process.kill(parseInt(pid), 'SIGKILL');
+                } catch (e) {
+                  // Ignore ESRCH errors when killing individual processes
+                  if (e.code !== 'ESRCH') throw e;
+                }
+              }
             });
           });
+          // Wait for lsof to complete
+          await new Promise((resolve) => lsof.on('close', resolve));
         }
       } catch (e) {
         // Ignore errors if no process found