mirror of
https://github.com/Cog-Creators/Red-DiscordBot.git
synced 2025-11-06 03:08:55 -05:00
* Kill JsonIO and fix JSON driver caching issues Signed-off-by: Toby Harradine <tobyharradine@gmail.com> * Ensure lock covers critical region in set() Signed-off-by: Toby Harradine <tobyharradine@gmail.com> * Make tests pass Signed-off-by: Toby Harradine <tobyharradine@gmail.com> * Use pickle over deepcopy in Config Signed-off-by: Toby Harradine <tobyharradine@gmail.com> * Fix temp instance creation Signed-off-by: Toby Harradine <tobyharradine@gmail.com> * Serialise value before doing anything in set() Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
225 lines
6.9 KiB
Python
225 lines
6.9 KiB
Python
import asyncio
|
|
import json
|
|
import logging
|
|
import os
|
|
import pickle
|
|
import weakref
|
|
from pathlib import Path
|
|
from typing import Any, Dict
|
|
from uuid import uuid4
|
|
|
|
from .red_base import BaseDriver, IdentifierData
|
|
|
|
__all__ = ["JSON"]
|
|
|
|
|
|
_shared_datastore = {}
|
|
_driver_counts = {}
|
|
_finalizers = []
|
|
|
|
log = logging.getLogger("redbot.json_driver")
|
|
|
|
|
|
def finalize_driver(cog_name):
|
|
if cog_name not in _driver_counts:
|
|
return
|
|
|
|
_driver_counts[cog_name] -= 1
|
|
|
|
if _driver_counts[cog_name] == 0:
|
|
if cog_name in _shared_datastore:
|
|
del _shared_datastore[cog_name]
|
|
|
|
for f in _finalizers:
|
|
if not f.alive:
|
|
_finalizers.remove(f)
|
|
|
|
|
|
class JSON(BaseDriver):
|
|
"""
|
|
Subclass of :py:class:`.red_base.BaseDriver`.
|
|
|
|
.. py:attribute:: file_name
|
|
|
|
The name of the file in which to store JSON data.
|
|
|
|
.. py:attribute:: data_path
|
|
|
|
The path in which to store the file indicated by :py:attr:`file_name`.
|
|
"""
|
|
|
|
def __init__(
|
|
self,
|
|
cog_name,
|
|
identifier,
|
|
*,
|
|
data_path_override: Path = None,
|
|
file_name_override: str = "settings.json"
|
|
):
|
|
super().__init__(cog_name, identifier)
|
|
self.file_name = file_name_override
|
|
if data_path_override:
|
|
self.data_path = data_path_override
|
|
else:
|
|
self.data_path = Path.cwd() / "cogs" / ".data" / self.cog_name
|
|
self.data_path.mkdir(parents=True, exist_ok=True)
|
|
self.data_path = self.data_path / self.file_name
|
|
|
|
self._lock = asyncio.Lock()
|
|
self._load_data()
|
|
|
|
async def has_valid_connection(self) -> bool:
|
|
return True
|
|
|
|
@property
|
|
def data(self):
|
|
return _shared_datastore.get(self.cog_name)
|
|
|
|
@data.setter
|
|
def data(self, value):
|
|
_shared_datastore[self.cog_name] = value
|
|
|
|
def _load_data(self):
|
|
if self.cog_name not in _driver_counts:
|
|
_driver_counts[self.cog_name] = 0
|
|
_driver_counts[self.cog_name] += 1
|
|
|
|
_finalizers.append(weakref.finalize(self, finalize_driver, self.cog_name))
|
|
|
|
if self.data is not None:
|
|
return
|
|
|
|
try:
|
|
with self.data_path.open("r", encoding="utf-8") as fs:
|
|
self.data = json.load(fs)
|
|
except FileNotFoundError:
|
|
self.data = {}
|
|
with self.data_path.open("w", encoding="utf-8") as fs:
|
|
json.dump(self.data, fs, indent=4)
|
|
|
|
def migrate_identifier(self, raw_identifier: int):
|
|
if self.unique_cog_identifier in self.data:
|
|
# Data has already been migrated
|
|
return
|
|
poss_identifiers = [str(raw_identifier), str(hash(raw_identifier))]
|
|
for ident in poss_identifiers:
|
|
if ident in self.data:
|
|
self.data[self.unique_cog_identifier] = self.data[ident]
|
|
del self.data[ident]
|
|
_save_json(self.data_path, self.data)
|
|
break
|
|
|
|
async def get(self, identifier_data: IdentifierData):
|
|
partial = self.data
|
|
full_identifiers = identifier_data.to_tuple()
|
|
for i in full_identifiers:
|
|
partial = partial[i]
|
|
return pickle.loads(pickle.dumps(partial, -1))
|
|
|
|
async def set(self, identifier_data: IdentifierData, value=None):
|
|
partial = self.data
|
|
full_identifiers = identifier_data.to_tuple()
|
|
# This is both our deepcopy() and our way of making sure this value is actually JSON
|
|
# serializable.
|
|
value_copy = json.loads(json.dumps(value))
|
|
|
|
async with self._lock:
|
|
for i in full_identifiers[:-1]:
|
|
if i not in partial:
|
|
partial[i] = {}
|
|
partial = partial[i]
|
|
partial[full_identifiers[-1]] = value_copy
|
|
|
|
await self._save()
|
|
|
|
async def clear(self, identifier_data: IdentifierData):
|
|
partial = self.data
|
|
full_identifiers = identifier_data.to_tuple()
|
|
try:
|
|
for i in full_identifiers[:-1]:
|
|
partial = partial[i]
|
|
except KeyError:
|
|
pass
|
|
else:
|
|
async with self._lock:
|
|
try:
|
|
del partial[full_identifiers[-1]]
|
|
except KeyError:
|
|
pass
|
|
else:
|
|
await self._save()
|
|
|
|
async def import_data(self, cog_data, custom_group_data):
|
|
def update_write_data(identifier_data: IdentifierData, _data):
|
|
partial = self.data
|
|
idents = identifier_data.to_tuple()
|
|
for ident in idents[:-1]:
|
|
if ident not in partial:
|
|
partial[ident] = {}
|
|
partial = partial[ident]
|
|
partial[idents[-1]] = _data
|
|
|
|
async with self._lock:
|
|
for category, all_data in cog_data:
|
|
splitted_pkey = self._split_primary_key(category, custom_group_data, all_data)
|
|
for pkey, data in splitted_pkey:
|
|
ident_data = IdentifierData(
|
|
self.unique_cog_identifier,
|
|
category,
|
|
pkey,
|
|
(),
|
|
custom_group_data,
|
|
is_custom=category in custom_group_data,
|
|
)
|
|
update_write_data(ident_data, data)
|
|
await self._save()
|
|
|
|
async def _save(self) -> None:
|
|
loop = asyncio.get_running_loop()
|
|
await loop.run_in_executor(None, _save_json, self.data_path, self.data)
|
|
|
|
def get_config_details(self):
|
|
return
|
|
|
|
|
|
def _save_json(path: Path, data: Dict[str, Any]) -> None:
|
|
"""
|
|
This fsync stuff here is entirely neccessary.
|
|
|
|
On windows, it is not available in entirety.
|
|
If a windows user ends up with tons of temp files, they should consider hosting on
|
|
something POSIX compatible, or using the mongo backend instead.
|
|
|
|
Most users wont encounter this issue, but with high write volumes,
|
|
without the fsync on both the temp file, and after the replace on the directory,
|
|
There's no real durability or atomicity guarantee from the filesystem.
|
|
|
|
In depth overview of underlying reasons why this is needed:
|
|
https://lwn.net/Articles/457667/
|
|
|
|
Also see:
|
|
http://man7.org/linux/man-pages/man2/open.2.html#NOTES (synchronous I/O section)
|
|
And:
|
|
https://www.mjmwired.net/kernel/Documentation/filesystems/ext4.txt#310
|
|
"""
|
|
filename = path.stem
|
|
tmp_file = "{}-{}.tmp".format(filename, uuid4().fields[0])
|
|
tmp_path = path.parent / tmp_file
|
|
with tmp_path.open(encoding="utf-8", mode="w") as fs:
|
|
json.dump(data, fs, indent=4)
|
|
fs.flush() # This does get closed on context exit, ...
|
|
os.fsync(fs.fileno()) # but that needs to happen prior to this line
|
|
|
|
tmp_path.replace(path)
|
|
|
|
try:
|
|
flag = os.O_DIRECTORY # pylint: disable=no-member
|
|
except AttributeError:
|
|
pass
|
|
else:
|
|
fd = os.open(path.parent, flag)
|
|
try:
|
|
os.fsync(fd)
|
|
finally:
|
|
os.close(fd)
|