* [streams]allowed_mentions on stream announcement
Allows role mentions for discord.py 1.4+
# Type
[x] Bugfix
[ ] Enhancement
[ ] New feature
Description of the changes
Referencing line 747. Gives permissions to mention role on stream announcement.
* Update streams.py
* Add `mention_everyone` defaults
Lines for reference:
- [751-753]:
```py
if can_mention_everyone:
await self.save_streams()
return # if bot can mention everyone already, let's stop here```
- [722-774]:
```py
if can_mention_everyone:
mentions.append(role.mention)
return # if bot can mention everyone already, let's stop here (part two)```
Hopefully, this is what you had in mind? Humbly admit I may not have a business in biting this piece but looking forward to feedback on the best methodology for the wanted outcome.
Thanks!
* *sweats*
* imagine variable naming
Should complete all passes.
* misplaced unindent on return
* Update redbot/cogs/streams/streams.py
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* Update redbot/cogs/streams/streams.py
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* Update redbot/cogs/streams/streams.py
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* You're a beast jack
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* this would cover all channels in guild (think)
* give this a reeeeee
* Update streams.py
* adds channel argument
https://github.com/Cog-Creators/Red-DiscordBot/pull/4182#pullrequestreview-468012281
* image style checking, self
* imagine
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* [Streams] Change hitbox to smashcast.
as hitbox is now smashcast.
* Add files via upload
* reee
* :thonk:
* oof
* Add missing new lines at end of file
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
[Core] Data Deletion And Disclosure APIs
- Adds a Data Deletion API
- Deletion comes in a few forms based on who is requesting
- Deletion must be handled by 3rd party
- Adds a Data Collection Disclosure Command
- Provides a dynamically generated statement from 3rd party
extensions
- Modifies the always available commands to be cog compatible
- Also prevents them from being unloaded accidentally
* create cog disbale base
* Because defaults...
* lol
* announcer needs to respect this
* defaultdict mishap
* Allow None as guild
- Mostly for interop with with ctx.guild
* a whitespace issue
* Apparently, I broke this too
* Apply suggestions from code review
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* This can probably be more optimized later, but since this is a cached value, it's not a large issue
* Report tunnel closing
* mod too
* whitespace issue
* Fix Artifact of prior method naming
* these 3 places should have the check if i understood it correctly
* Announce the closed tunnels
* tunnel oversight
* Make the player stop at next track
* added where draper said to put it
* Apply suggestions from code review
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Co-authored-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
* hopefully all strings in streams.py
* black streams.py
* don't touch docstrings
* uniformity is good
* thx draper
Co-authored-by: Draper <27962761+Drapersniper@users.noreply.github.com>
* aaaaaaaaaaaaaaaaaaaaaa
* translate more
* sure, joining some strings for jack
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* more strings to join
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* yup... I missed this
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* jaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaack blaaaaaaaaaaaaaaaaaaaaaack
Co-authored-by: Draper <27962761+Drapersniper@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* Send Notify owner messages only when a key has been invalidated since last notify_owner
* grammar
* welp im dumb
* Black and lower config call frequency
* Update redbot/cogs/streams/streams.py
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* dont use a generic name now to avoid a config migration later
* be even more explicit with var name
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
* Lets normalize how we name config attributes across the bot.
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
* ....
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
* nothing to see here
Signed-off-by: Drapersniper <27962761+drapersniper@users.noreply.github.com>
* use correct prefixes when sending messages to owners
* make internal util for this instead
* oops
* fix circular import
* let's add back the actual fix I made this PR for...
* fix wrong logger name
* improve log message
* Rename `bot.db` as `bot._config`
- Continues work towards strong version guarantees
- Added methods for cog use for a few things which were previously
only accessible via direct access.
- Retained private use in a few internal use locations, though most
methods were updated away from this.
- Updated documentation for shared api token users
* changelog
* more detail
* docstring fixes
* Apparently, I forgot to commit something I had locally
- + a copy/paste failue in the changelog
* *sigh*:
* *sigh*
* Fixes some issues with `[p]streamset youtubekey/twitchtoken`
Lots of general formatting bugs and clarity issues.
* General formatting bugs and clarity issues
- fixes#2696
- My fault for just looking at the github diff and seeing the logic fix
on this one, without verifying the name validity in surrounding
context. (see my review in #2679)
* [Streams] Add ability to exclude rerun streams from alerts
* [Docs] Changelog entries for contributions by EgonSpengler
* Changelog entry for #2620 [Streams] Ignore Reruns In Alerts
* Dependency update
discord.py==1.0.1
websockets<7
[style]
black==19.3b0
[Docs]
jinja==2.10.1
urllib3==1.24.2
Changes related to breaking changes from discord.py have also been made
to match
As of this commit, help formatter is back to discord.py's default
This creates a central location to store external API tokens that can be used between cogs without requiring each cog to be loaded for it to work.
A new set option for `[p]set api` is created to assist in forming bot readable API token locations.
This also updates the Streams cog to utilize the central database.
Tokens are moved from the old data locations in core cogs on load.
API changes:
- Cogs must now inherit from `commands.Cog` (see #2151 for discussion and more details)
- All functions which are not decorators in the `redbot.core.checks` module are now deprecated in favour of their counterparts in `redbot.core.utils.mod`. This is to make this module more consistent and end the confusing naming convention.
- `redbot.core.checks.check_overrides` function is now gone, overrideable checks can now be created with the `@commands.permissions_check` decorator
- Command, Group, Cog and Context have some new attributes and methods, but they are for internal use so shouldn't concern cog creators (unless they're making a permissions cog!).
- `__permissions_check_before` and `__permissions_check_after` have been replaced: A cog method named `__permissions_hook` will be evaluated as permissions hooks in the same way `__permissions_check_before` previously was. Permissions hooks can also be added/removed/verified through the new `*_permissions_hook()` methods on the bot object, and they will be verified even when permissions is unloaded.
- New utility method `redbot.core.utils.chat_formatting.humanize_list`
- New dependency [`schema`](https://github.com/keleshev/schema)
User-facing changes:
- When a `@bot_has_permissions` check fails, the bot will respond saying what permissions were actually missing.
- All YAML-related `[p]permissions` subcommands now reside under the `[p]permissions acl` sub-group (tbh I still think the whole cog has too many top-level commands)
- The YAML schema for these commands has been changed
- A rule cannot be set as allow and deny at the same time (previously this would just default to allow)
Documentation:
- New documentation for `redbot.core.commands.requires` and `redbot.core.checks` modules
- Renewed documentation for the permissions cog
- `sphinx.ext.doctest` is now enabled
Note: standard discord.py checks will still behave exactly the same way, in fact they are checked before `Requires` is looked at, so they are not overrideable.
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
* [Streams] Set YouTube channel name when added by ID
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
* Move unset token raise to correct place
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
* Correct logic in get_stream
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
* Fetch name explicitly instead
Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
