From ef3ac77bd8a652d90de478ccc67247179550c6a8 Mon Sep 17 00:00:00 2001 From: DJtheRedstoner <52044242+DJtheRedstoner@users.noreply.github.com> Date: Fri, 30 Aug 2019 17:20:34 -0400 Subject: [PATCH] Fix issues with embed_requested() (#2966) * Fix issues with embed_requested() * Update embed_requested() Make embed_requested()'s user settings only affect DM's * Towncrier for #2966 --- changelog.d/2966.bugfix.rst | 1 + redbot/core/bot.py | 4 +--- 2 files changed, 2 insertions(+), 3 deletions(-) create mode 100644 changelog.d/2966.bugfix.rst diff --git a/changelog.d/2966.bugfix.rst b/changelog.d/2966.bugfix.rst new file mode 100644 index 000000000..b615eace2 --- /dev/null +++ b/changelog.d/2966.bugfix.rst @@ -0,0 +1 @@ +Make embedset user only affect DM's diff --git a/redbot/core/bot.py b/redbot/core/bot.py index a7c82f058..6a2150a25 100644 --- a/redbot/core/bot.py +++ b/redbot/core/bot.py @@ -203,9 +203,7 @@ class RedBase(commands.GroupMixin, commands.bot.BotBase, RPCMixin): # pylint: d bool :code:`True` if an embed is requested """ - if isinstance(channel, discord.abc.PrivateChannel) or ( - command and command == self.get_command("help") - ): + if isinstance(channel, discord.abc.PrivateChannel): user_setting = await self.db.user(user).embeds() if user_setting is not None: return user_setting