From d52f8974fdf011100d9206537606651147fd9b0e Mon Sep 17 00:00:00 2001 From: Michael H Date: Fri, 17 Jan 2020 17:59:37 -0500 Subject: [PATCH] Stop special casing help in bot.embed_requested (#3382) - However, we are not changing the signature - This was previously special cased for reasons related to the older version of the help formatter we used and never re-evaluated for need. - We should leave the signature as is both for lack of breaking, and for potential future changes // actually this was already done once in GH-2966 but got accidentally overwritten --- redbot/core/bot.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/redbot/core/bot.py b/redbot/core/bot.py index 9c7e56408..5ad380f62 100644 --- a/redbot/core/bot.py +++ b/redbot/core/bot.py @@ -614,9 +614,7 @@ class RedBase(commands.GroupMixin, commands.bot.BotBase, RPCMixin): # pylint: d bool :code:`True` if an embed is requested """ - if isinstance(channel, discord.abc.PrivateChannel) or ( - command and command == self.get_command("help") - ): + if isinstance(channel, discord.abc.PrivateChannel): user_setting = await self._config.user(user).embeds() if user_setting is not None: return user_setting @@ -624,6 +622,7 @@ class RedBase(commands.GroupMixin, commands.bot.BotBase, RPCMixin): # pylint: d guild_setting = await self._config.guild(channel.guild).embeds() if guild_setting is not None: return guild_setting + global_setting = await self._config.embeds() return global_setting