From c4d295b25d82ac581a3c264ce5f5ae4a63de9a49 Mon Sep 17 00:00:00 2001 From: jack1142 <6032823+jack1142@users.noreply.github.com> Date: Fri, 10 Jul 2020 22:42:31 +0200 Subject: [PATCH] Ignore that the rule for model doesn't exist when trying to remove it (#4036) --- redbot/cogs/permissions/permissions.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/redbot/cogs/permissions/permissions.py b/redbot/cogs/permissions/permissions.py index 0b9c0b218..b93c3ff9e 100644 --- a/redbot/cogs/permissions/permissions.py +++ b/redbot/cogs/permissions/permissions.py @@ -599,8 +599,8 @@ class Permissions(commands.Cog): cog_or_cmd.obj.clear_rule_for(model_id, guild_id=guild_id) guild_id, model_id = str(guild_id), str(model_id) async with self.config.custom(cog_or_cmd.type, cog_or_cmd.name).all() as rules: - if guild_id in rules and rules[guild_id]: - del rules[guild_id][model_id] + if (guild_rules := rules.get(guild_id)) is not None: + guild_rules.pop(model_id, None) async def _set_default_rule( self, rule: Optional[bool], cog_or_cmd: CogOrCommand, guild_id: int