diff --git a/changelog.d/downloader/3173.misc.rst b/changelog.d/downloader/3173.misc.rst new file mode 100644 index 000000000..ba4902a47 --- /dev/null +++ b/changelog.d/downloader/3173.misc.rst @@ -0,0 +1 @@ +Downloader will no longer show update for a cog if the latest version is disabled through ``info.json`` file. \ No newline at end of file diff --git a/redbot/cogs/downloader/downloader.py b/redbot/cogs/downloader/downloader.py index 3913cc739..e18fe8402 100644 --- a/redbot/cogs/downloader/downloader.py +++ b/redbot/cogs/downloader/downloader.py @@ -252,7 +252,7 @@ class Downloader(commands.Cog): continue # marking cog for update if there's no commit data saved (back-compat, see GH-2571) last_cog_occurrence = await cog.repo.get_last_module_occurrence(cog.name) - if last_cog_occurrence is not None: + if last_cog_occurrence is not None and not last_cog_occurrence.disabled: cogs_to_update.add(last_cog_occurrence) # Reduces diff requests to a single dict with no repeats @@ -277,7 +277,8 @@ class Downloader(commands.Cog): else: modified_module = modified[index] if modified_module.type == InstallableType.COG: - cogs_to_update.add(modified_module) + if not modified_module.disabled: + cogs_to_update.add(modified_module) elif modified_module.type == InstallableType.SHARED_LIBRARY: libraries_to_update.add(modified_module)