From b9e2e1098fd75bcf7c56ddb5276c77ff57b2e54d Mon Sep 17 00:00:00 2001
From: jack1142 <6032823+jack1142@users.noreply.github.com>
Date: Thu, 19 Mar 2020 08:21:54 +0100
Subject: [PATCH] [Trivia] Forbid use of non-finite numbers in `[p]triviaset`
 subcommands (#3668)

* Update trivia.py

* style
---
 redbot/cogs/trivia/trivia.py | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/redbot/cogs/trivia/trivia.py b/redbot/cogs/trivia/trivia.py
index 046aefbba..b288be60c 100644
--- a/redbot/cogs/trivia/trivia.py
+++ b/redbot/cogs/trivia/trivia.py
@@ -1,9 +1,12 @@
 """Module for Trivia cog."""
+import math
 import pathlib
 from collections import Counter
 from typing import List
+
 import yaml
 import discord
+
 from redbot.core import commands
 from redbot.core import Config, checks
 from redbot.core.data_manager import cog_data_path
@@ -20,6 +23,16 @@ UNIQUE_ID = 0xB3C0E453
 _ = Translator("Trivia", __file__)
 
 
+def finite_float(arg: str) -> float:
+    try:
+        ret = float(arg)
+    except ValueError:
+        raise commands.BadArgument(_("`{arg}` is not a number.").format(arg=arg))
+    if not math.isfinite(ret):
+        raise commands.BadArgument(_("`{arg}` is not a finite number.").format(arg=ret))
+    return ret
+
+
 class InvalidListError(Exception):
     """A Trivia list file is in invalid format."""
 
@@ -81,7 +94,7 @@ class Trivia(commands.Cog):
         await ctx.send(_("Done. Points required to win set to {num}.").format(num=score))
 
     @triviaset.command(name="timelimit")
-    async def triviaset_timelimit(self, ctx: commands.Context, seconds: float):
+    async def triviaset_timelimit(self, ctx: commands.Context, seconds: finite_float):
         """Set the maximum seconds permitted to answer a question."""
         if seconds < 4.0:
             await ctx.send(_("Must be at least 4 seconds."))
@@ -91,7 +104,7 @@ class Trivia(commands.Cog):
         await ctx.send(_("Done. Maximum seconds to answer set to {num}.").format(num=seconds))
 
     @triviaset.command(name="stopafter")
-    async def triviaset_stopafter(self, ctx: commands.Context, seconds: float):
+    async def triviaset_stopafter(self, ctx: commands.Context, seconds: finite_float):
         """Set how long until trivia stops due to no response."""
         settings = self.conf.guild(ctx.guild)
         if seconds < await settings.delay():
@@ -150,7 +163,7 @@ class Trivia(commands.Cog):
 
     @triviaset.command(name="payout")
     @check_global_setting_admin()
-    async def triviaset_payout_multiplier(self, ctx: commands.Context, multiplier: float):
+    async def triviaset_payout_multiplier(self, ctx: commands.Context, multiplier: finite_float):
         """Set the payout multiplier.
 
         This can be any positive decimal number. If a user wins trivia when at