From a7ec40664e22bbddafcf50bcf17e967204f00c1e Mon Sep 17 00:00:00 2001 From: jack1142 <6032823+jack1142@users.noreply.github.com> Date: Sat, 7 Nov 2020 03:44:59 +0100 Subject: [PATCH] Fix `reason` variable shadowing in `[p]massban` (#4575) --- redbot/cogs/mod/kickban.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/redbot/cogs/mod/kickban.py b/redbot/cogs/mod/kickban.py index f5617fad9..e87005ff6 100644 --- a/redbot/cogs/mod/kickban.py +++ b/redbot/cogs/mod/kickban.py @@ -462,14 +462,15 @@ class KickBanMixin(MixinMeta): # Call `ban_user()` method for all users that turned out to be guild members. for user_id, member in members.items(): try: - success, reason = await self.ban_user( + # using `reason` here would shadow the reason passed to command + success, failure_reason = await self.ban_user( user=member, ctx=ctx, days=days, reason=reason, create_modlog_case=True ) if success: banned.append(user_id) else: errors[user_id] = _("Failed to ban user {user_id}: {reason}").format( - user_id=user_id, reason=reason + user_id=user_id, reason=failure_reason ) except Exception as e: errors[user_id] = _("Failed to ban user {user_id}: {reason}").format(