CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-11-06 11:18:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

[Mod] Handle invalid nicknames in [p]rename (#2311)

Browse Source
This commit is contained in:
Kowlin 2018-12-16 01:21:36 +01:00 committed by Toby Harradine
parent 38b15ded87
commit a5efdc6492
1 changed files with 32 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
redbot/cogs/mod/mod.py
View File

@ -866,16 +866,42 @@ class Mod(commands.Cog):
@commands.guild_only() @commands.guild_only()
@commands.bot_has_permissions(manage_nicknames=True) @commands.bot_has_permissions(manage_nicknames=True)
@checks.admin_or_permissions(manage_nicknames=True) @checks.admin_or_permissions(manage_nicknames=True)
async def rename(self, ctx: commands.Context, user: discord.Member, *, nickname=""): async def rename(self, ctx: commands.Context, user: discord.Member, *, nickname: str = ""):
"""Change a user's nickname. """Change a user's nickname.
Leaving the nickname empty will remove it. Leaving the nickname empty will remove it.
""" """
nickname = nickname.strip() nickname = nickname.strip()
if nickname == "": me = cast(discord.Member, ctx.me)
if not nickname:
nickname = None nickname = None
elif not 2 <= len(nickname) <= 32:
await ctx.send(_("Nicknames must be between 2 and 32 characters long."))
return
if not (
(me.guild_permissions.manage_nicknames or me.guild_permissions.administrator)
and me.top_role > user.top_role
and user != ctx.guild.owner
):
await ctx.send(
_(
"I do not have permission to rename that member. They may be higher than or "
"equal to me in the role hierarchy."
)
)
else:
try:
await user.edit(reason=get_audit_reason(ctx.author, None), nick=nickname) await user.edit(reason=get_audit_reason(ctx.author, None), nick=nickname)
await ctx.send("Done.") except discord.Forbidden:
# Just in case we missed something in the permissions check above
await ctx.send(_("I do not have permission to rename that member."))
except discord.HTTPException as exc:
if exc.status == 400: # BAD REQUEST
await ctx.send(_("That nickname is invalid."))
else:
await ctx.send(_("An unexpected error has occured."))
else:
await ctx.send(_("Done."))
@commands.group() @commands.group()
@commands.guild_only() @commands.guild_only()
@ -1308,8 +1334,8 @@ class Mod(commands.Cog):
user = author user = author
# A special case for a special someone :^) # A special case for a special someone :^)
special_date = datetime(2016, 1, 10, 6, 8, 4, 443000) special_date = datetime(2016, 1, 10, 6, 8, 4, 443_000)
is_special = user.id == 96130341705637888 and guild.id == 133049272517001216 is_special = user.id == 96_130_341_705_637_888 and guild.id == 133_049_272_517_001_216
roles = sorted(user.roles)[1:] roles = sorted(user.roles)[1:]
names, nicks = await self.get_names_and_nicks(user) names, nicks = await self.get_names_and_nicks(user)