CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-11-06 03:08:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix behavior of the menu() function calls without user param (#6324)

Browse Source
This commit is contained in:
Jakub Kuczys 2024-03-24 00:16:44 +01:00 committed by GitHub
parent 76c2c75f2c
commit a26b9d6d3a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES.rst
View File

@ -63,12 +63,12 @@ Changes
- **Core - Utils Package** - The `menu()` utility function received a new `provisional <developer-guarantees-exclusions>` ``user`` parameter for defining who can interact with the menu (instead of the default ``ctx.author``) (:issue:`4913`) - **Core - Utils Package** - The `menu()` utility function received a new `provisional <developer-guarantees-exclusions>` ``user`` parameter for defining who can interact with the menu (instead of the default ``ctx.author``) (:issue:`4913`)
If no issues arise, we plan on including this parameter under developer guarantees If no issues arise, we plan on including this parameter under developer guarantees
in the first release made after 2024-05-18. in the first release made after 2024-05-24.
- **Core - Utils Package** - The `SimpleMenu.start()` method received a new `provisional <developer-guarantees-exclusions>` ``user`` parameter for defining who can interact with the menu (instead of the default ``ctx.author``) (:issue:`4913`) - **Core - Utils Package** - The `SimpleMenu.start()` method received a new `provisional <developer-guarantees-exclusions>` ``user`` parameter for defining who can interact with the menu (instead of the default ``ctx.author``) (:issue:`4913`)
If no issues arise, we plan on including this parameter under developer guarantees If no issues arise, we plan on including this parameter under developer guarantees
in the first release made after 2024-05-18. in the first release made after 2024-05-24.
Fixes Fixes
***** *****

6
redbot/core/utils/menus.py
View File

@ -80,7 +80,7 @@ async def menu(
The ``user`` parameter is considered `provisional <developer-guarantees-exclusions>`. The ``user`` parameter is considered `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18. in the first release made after 2024-05-24.
.. warning:: .. warning::
@ -168,7 +168,7 @@ async def menu(
This parameter is `provisional <developer-guarantees-exclusions>`. This parameter is `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18. in the first release made after 2024-05-24.
Raises Raises
------ ------
@ -287,7 +287,7 @@ async def menu(
if len(done) == 0: if len(done) == 0:
raise asyncio.TimeoutError() raise asyncio.TimeoutError()
react, user = done.pop().result() react, __ = done.pop().result()
except asyncio.TimeoutError: except asyncio.TimeoutError:
if not ctx.me: if not ctx.me:
return return

4
redbot/core/utils/views.py
View File

@ -249,7 +249,7 @@ class SimpleMenu(discord.ui.View):
The ``user`` parameter is considered `provisional <developer-guarantees-exclusions>`. The ``user`` parameter is considered `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18. in the first release made after 2024-05-24.
Parameters Parameters
---------- ----------
@ -263,7 +263,7 @@ class SimpleMenu(discord.ui.View):
This parameter is `provisional <developer-guarantees-exclusions>`. This parameter is `provisional <developer-guarantees-exclusions>`.
If no issues arise, we plan on including it under developer guarantees If no issues arise, we plan on including it under developer guarantees
in the first release made after 2024-05-18. in the first release made after 2024-05-24.
ephemeral: `bool` ephemeral: `bool`
Send the message ephemerally. This only works Send the message ephemerally. This only works
if the context is from a slash command interaction. if the context is from a slash command interaction.