CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-11-19 17:36:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

[Permissions] Fix ValueError for "default" rule in config/ACL (#2200)

Browse Source 
This was thrown when the "default" key existed and Permissions tried to iterate over the list mapping keys as ints.

Also fixed some issues with saving config with keys as `int` instead of `str`.

Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
This commit is contained in:
Toby Harradine
2018-10-09 15:14:59 +11:00
committed by GitHub
parent 9e13ca45e6
commit 9217275908
2 changed files with 31 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/cogs/test_permissions.py
View File

@@ -3,7 +3,7 @@ from redbot.cogs.permissions.permissions import Permissions, GLOBAL
def test_schema_update():
old = {
GLOBAL: {
str(GLOBAL): {
"owner_models": {
"cogs": {
"Admin": {"allow": [78631113035100160], "deny": [96733288462286848]},
@@ -19,7 +19,7 @@ def test_schema_update():
},
}
},
43733288462286848: {
"43733288462286848": {
"owner_models": {
"cogs": {
"Admin": {
@@ -43,22 +43,22 @@ def test_schema_update():
assert new == (
{
"Admin": {
GLOBAL: {78631113035100160: True, 96733288462286848: False},
43733288462286848: {24231113035100160: True, 35533288462286848: False},
str(GLOBAL): {"78631113035100160": True, "96733288462286848": False},
"43733288462286848": {"24231113035100160": True, "35533288462286848": False},
},
"Audio": {GLOBAL: {133049272517001216: True, "default": False}},
"General": {43733288462286848: {133049272517001216: True, "default": False}},
"Audio": {str(GLOBAL): {"133049272517001216": True, "default": False}},
"General": {"43733288462286848": {"133049272517001216": True, "default": False}},
},
{
"cleanup bot": {
GLOBAL: {78631113035100160: True, "default": False},
43733288462286848: {17831113035100160: True, "default": True},
str(GLOBAL): {"78631113035100160": True, "default": False},
"43733288462286848": {"17831113035100160": True, "default": True},
},
"ping": {GLOBAL: {96733288462286848: True, "default": True}},
"ping": {str(GLOBAL): {"96733288462286848": True, "default": True}},
"set adminrole": {
43733288462286848: {
87733288462286848: True,
95433288462286848: False,
"43733288462286848": {
"87733288462286848": True,
"95433288462286848": False,
"default": True,
}
},