From 8ae84b7c8100bd92cdb83a2ac2402b2f09fef693 Mon Sep 17 00:00:00 2001
From: Kowlin <Kowlin@users.noreply.github.com>
Date: Wed, 23 Dec 2020 21:00:55 +0100
Subject: [PATCH] [Streams] Remove the blank suppression of errors (#4680)

* [Streams] Remove the blank suppression of errors

* Okay, maybe do gracefully handle it a little bit...

* Update redbot/cogs/streams/streams.py

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
---
 redbot/cogs/streams/streams.py | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/redbot/cogs/streams/streams.py b/redbot/cogs/streams/streams.py
index ac81d9327..311a15e59 100644
--- a/redbot/cogs/streams/streams.py
+++ b/redbot/cogs/streams/streams.py
@@ -725,13 +725,15 @@ class Streams(commands.Cog):
 
     async def check_streams(self):
         for stream in self.streams:
-            with contextlib.suppress(Exception):
+            try:
                 try:
                     if stream.__class__.__name__ == "TwitchStream":
                         await self.maybe_renew_twitch_bearer_token()
                         embed, is_rerun = await stream.is_online()
+
                     elif stream.__class__.__name__ == "YoutubeStream":
                         embed, is_schedule = await stream.is_online()
+
                     else:
                         embed = await stream.is_online()
                         is_rerun = False
@@ -740,11 +742,11 @@ class Streams(commands.Cog):
                     if not stream._messages_cache:
                         continue
                     for message in stream._messages_cache:
-                        with contextlib.suppress(Exception):
-                            if await self.bot.cog_disabled_in_guild(self, message.guild):
-                                continue
-                            autodelete = await self.config.guild(message.guild).autodelete()
-                            if autodelete:
+                        if await self.bot.cog_disabled_in_guild(self, message.guild):
+                            continue
+                        autodelete = await self.config.guild(message.guild).autodelete()
+                        if autodelete:
+                            with contextlib.suppress(discord.NotFound):
                                 await message.delete()
                     stream._messages_cache.clear()
                     await self.save_streams()
@@ -813,6 +815,8 @@ class Streams(commands.Cog):
                             for role in edited_roles:
                                 await role.edit(mentionable=False)
                         await self.save_streams()
+            except Exception as e:
+                log.error("An error has occured with Streams. Please report it.", exc_info=e)
 
     async def _get_mention_str(
         self, guild: discord.Guild, channel: discord.TextChannel