CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-11-06 03:08:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

[V3 Downloader] Fix #1671 (#1692)

Browse Source
This commit is contained in:
Will 2018-05-22 20:54:00 -04:00 committed by GitHub
parent c42e9d4c5c
commit 889acaec82
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
redbot/cogs/downloader/repo_manager.py
View File

@ -537,8 +537,8 @@ class RepoManager:
""" """
if self.does_repo_exist(name): if self.does_repo_exist(name):
raise InvalidRepoName( raise ExistingGitRepo(
"That repo name you provided already exists." " Please choose another." "That repo name you provided already exists. Please choose another."
) )
# noinspection PyTypeChecker # noinspection PyTypeChecker

12
tests/cogs/downloader/test_downloader.py
View File

@ -3,9 +3,11 @@ from collections import namedtuple
from pathlib import Path from pathlib import Path
import pytest import pytest
from unittest.mock import MagicMock
from raven.versioning import fetch_git_sha from raven.versioning import fetch_git_sha
from redbot.cogs.downloader.repo_manager import RepoManager, Repo from redbot.cogs.downloader.repo_manager import RepoManager, Repo
from redbot.cogs.downloader.errors import ExistingGitRepo
async def fake_run(*args, **kwargs): async def fake_run(*args, **kwargs):
@ -129,3 +131,13 @@ async def test_current_hash(bot_repo):
sentry_sha = fetch_git_sha(str(bot_repo.folder_path)) sentry_sha = fetch_git_sha(str(bot_repo.folder_path))
assert sentry_sha == commit assert sentry_sha == commit
@pytest.mark.asyncio
async def test_existing_repo(repo_manager):
repo_manager.does_repo_exist = MagicMock(return_value=True)
with pytest.raises(ExistingGitRepo):
await repo_manager.add_repo("http://test.com", "test")
repo_manager.does_repo_exist.assert_called_once_with("test")