[V3 Config] Redesign "all_from_XXX" and "clear_all" methods (#1033)

* Added alternative to all_from_kind

* Returned dicts include default values

Also added docstrings

Also removed all_globals since it's kind of redundant and it wasn't working out for me

* Refactored clear_all

* Tests

* Tests again..

* Make all new methods coroutines
This commit is contained in:
Tobotimus
2017-10-20 14:22:58 +11:00
committed by Will
parent 13fef45e06
commit 815678584f
4 changed files with 257 additions and 112 deletions

View File

@@ -234,16 +234,16 @@ async def test_get_dynamic_attr(config):
async def test_membergroup_allguilds(config, empty_member):
await config.member(empty_member).foo.set(False)
all_servers = await config.member(empty_member).all_guilds()
assert str(empty_member.guild.id) in all_servers
all_servers = await config.all_members()
assert empty_member.guild.id in all_servers
@pytest.mark.asyncio
async def test_membergroup_allmembers(config, empty_member):
await config.member(empty_member).foo.set(False)
all_members = await config.member(empty_member).all_from_kind()
assert str(empty_member.id) in all_members
all_members = await config.all_members(empty_member.guild)
assert empty_member.id in all_members
# Clearing testing
@@ -291,11 +291,11 @@ async def test_member_clear_all(config, member_factory):
server_ids.append(member.guild.id)
member = member_factory.get()
assert len(await config.member(member).all_guilds()) == len(server_ids)
assert len(await config.all_members()) == len(server_ids)
await config.member(member).clear_all()
await config.clear_all_members()
assert len(await config.member(member).all_guilds()) == 0
assert len(await config.all_members()) == 0
# Get All testing
@@ -309,8 +309,7 @@ async def test_user_get_all_from_kind(config, user_factory):
user = user_factory.get()
await config.user(user).foo.set(True)
user = user_factory.get()
all_data = await config.user(user).all_from_kind()
all_data = await config.all_users()
assert len(all_data) == 5