CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-11-07 19:58:54 -05:00
Code Issues Packages Projects Releases Wiki Activity

[V3 Help][ fix help_formatter to obey length limits (#1375)

Browse Source 
Help didn't account for docstrings passing length limits which I noticed a while ago and as noticed again when Palm forgot a dual newline in a command docstring.
This PR sees to fix this by enforcing length limits on description, field names and field values
This commit is contained in:
James 2018-03-06 12:10:56 +13:00 committed by Tobotimus
parent 57b7db6956
commit 40c37b5c06
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
redbot/core/help_formatter.py
View File

@ -139,7 +139,7 @@ class Help(formatter.HelpFormatter):
if description: if description:
# <description> portion # <description> portion
emb['embed']['description'] = description emb['embed']['description'] = description[:2046]
if isinstance(self.command, discord.ext.commands.core.Command): if isinstance(self.command, discord.ext.commands.core.Command):
# <signature portion> # <signature portion>
@ -149,11 +149,11 @@ class Help(formatter.HelpFormatter):
# <long doc> section # <long doc> section
if self.command.help: if self.command.help:
name = '__{0}__'.format(self.command.help.split('\n\n')[0]) name = '__{0}__'.format(self.command.help.split('\n\n')[0])
name_length = len(name) - 4 name_length = len(name)
value = self.command.help[name_length:].replace('[p]', self.clean_prefix) value = self.command.help[name_length:].replace('[p]', self.clean_prefix)
if value == '': if value == '':
value = EMPTY_STRING value = EMPTY_STRING
field = EmbedField(name, value, False) field = EmbedField(name[:252], value[:1024], False)
emb['fields'].append(field) emb['fields'].append(field)
# end it here if it's just a regular command # end it here if it's just a regular command