[Core V3] Make the bot data path configurable (#879)

* Initial commit

* Fix sentry

* Make cog manager install path work relative to the bot's dir

* Fix downloader to save data relative to the defined data folder

* Fix sentry test

* Fix downloader tests

* Change logfile location

* Add another line to codeowners

* Basic tests

* Fix versioning

* Add in FutureWarning for config file changes

* Add reference to issue

tests/cogs/downloader/test_downloader.py

@@ -31,7 +31,7 @@ def patch_relative_to(monkeysession):
 def repo_manager(tmpdir_factory, config):
     config.register_global(repos={})
     rm = RepoManager(config)
-    rm.repos_folder = Path(str(tmpdir_factory.getbasetemp())) / 'repos'
+    # rm.repos_folder = Path(str(tmpdir_factory.getbasetemp())) / 'repos'
     return rm
 
 

tests/conftest.py

@@ -17,6 +17,13 @@ def monkeysession(request):
     mpatch.undo()
 
 
+@pytest.fixture(autouse=True)
+def override_data_path(tmpdir):
+    from core import data_manager
+    data_manager.basic_config = data_manager.basic_config_default
+    data_manager.basic_config['DATA_PATH'] = str(tmpdir)
+
+
 @pytest.fixture()
 def json_driver(tmpdir_factory):
     import uuid

tests/core/test_data_manager.py

@@ -0,0 +1,41 @@
+import json
+from pathlib import Path
+
+from core import data_manager
+import pytest
+
+
+@pytest.fixture(autouse=True)
+def cleanup_datamanager():
+    data_manager.basic_config = None
+    data_manager.jsonio = None
+
+
+@pytest.fixture()
+def data_mgr_config(tmpdir):
+    default = data_manager.basic_config_default.copy()
+    default['BASE_DIR'] = str(tmpdir)
+    return default
+
+
+@pytest.fixture()
+def cog_instance():
+    thing = type('CogTest', (object, ), {})
+    return thing()
+
+
+def test_no_basic(cog_instance):
+    with pytest.raises(RuntimeError):
+        data_manager.core_data_path()
+
+    with pytest.raises(RuntimeError):
+        data_manager.cog_data_path(cog_instance)
+
+
+def test_core_path(data_mgr_config, tmpdir):
+    conf_path = tmpdir.join('config.json')
+    conf_path.write(json.dumps(data_mgr_config))
+
+    data_manager.load_basic_configuration(Path(str(conf_path)))
+
+    assert data_manager.core_data_path().parent == Path(data_mgr_config['BASE_DIR'])

tests/core/test_sentry.py

@@ -2,9 +2,9 @@ from core import sentry_setup
 import logging
 
 
-def test_sentry_capture():
+def test_sentry_capture(red):
     log = logging.getLogger(__name__)
-    sentry_setup.init_sentry_logging(log)
+    sentry_setup.init_sentry_logging(red, log)
 
     assert sentry_setup.client is not None