[Permissions] Allow for multiple IDs in permissions rule commands. (#2448)

Use `commands.Greedy` to apply multiple rules at once.

closes #2214
This commit is contained in:
DiscordLiz 2019-04-02 22:53:07 -04:00 committed by Will
parent 0f9501f93a
commit 30af83aa6a

View File

@ -278,7 +278,7 @@ class Permissions(commands.Cog):
ctx: commands.Context,
allow_or_deny: RuleType,
cog_or_command: CogOrCommand,
who_or_what: GlobalUniqueObjectFinder,
who_or_what: commands.Greedy[GlobalUniqueObjectFinder],
):
"""Add a global rule to a command.
@ -287,15 +287,15 @@ class Permissions(commands.Cog):
`<cog_or_command>` is the cog or command to add the rule to.
This is case sensitive.
`<who_or_what>` is the user, channel, role or server the rule
is for.
`<who_or_what>` is one or more users, channels or roles the rule is for.
"""
await self._add_rule(
rule=cast(bool, allow_or_deny),
cog_or_cmd=cog_or_command,
model_id=who_or_what.id,
guild_id=0,
)
for w in who_or_what:
await self._add_rule(
rule=cast(bool, allow_or_deny),
cog_or_cmd=cog_or_command,
model_id=w.id,
guild_id=0,
)
await ctx.send(_("Rule added."))
@commands.guild_only()
@ -306,7 +306,7 @@ class Permissions(commands.Cog):
ctx: commands.Context,
allow_or_deny: RuleType,
cog_or_command: CogOrCommand,
who_or_what: GuildUniqueObjectFinder,
who_or_what: commands.Greedy[GuildUniqueObjectFinder],
):
"""Add a rule to a command in this server.
@ -315,14 +315,15 @@ class Permissions(commands.Cog):
`<cog_or_command>` is the cog or command to add the rule to.
This is case sensitive.
`<who_or_what>` is the user, channel or role the rule is for.
`<who_or_what>` is one or more users, channels or roles the rule is for.
"""
await self._add_rule(
rule=cast(bool, allow_or_deny),
cog_or_cmd=cog_or_command,
model_id=who_or_what.id,
guild_id=ctx.guild.id,
)
for w in who_or_what:
await self._add_rule(
rule=cast(bool, allow_or_deny),
cog_or_cmd=cog_or_command,
model_id=w.id,
guild_id=ctx.guild.id,
)
await ctx.send(_("Rule added."))
@checks.is_owner()
@ -331,19 +332,17 @@ class Permissions(commands.Cog):
self,
ctx: commands.Context,
cog_or_command: CogOrCommand,
who_or_what: GlobalUniqueObjectFinder,
who_or_what: commands.Greedy[GlobalUniqueObjectFinder],
):
"""Remove a global rule from a command.
`<cog_or_command>` is the cog or command to remove the rule
from. This is case sensitive.
`<who_or_what>` is the user, channel, role or server the rule
is for.
`<who_or_what>` is one or more users, channels or roles the rule is for.
"""
await self._remove_rule(
cog_or_cmd=cog_or_command, model_id=who_or_what.id, guild_id=GLOBAL
)
for w in who_or_what:
await self._remove_rule(cog_or_cmd=cog_or_command, model_id=w.id, guild_id=GLOBAL)
await ctx.send(_("Rule removed."))
@commands.guild_only()
@ -353,19 +352,19 @@ class Permissions(commands.Cog):
self,
ctx: commands.Context,
cog_or_command: CogOrCommand,
*,
who_or_what: GuildUniqueObjectFinder,
who_or_what: commands.Greedy[GlobalUniqueObjectFinder],
):
"""Remove a server rule from a command.
`<cog_or_command>` is the cog or command to remove the rule
from. This is case sensitive.
`<who_or_what>` is the user, channel or role the rule is for.
`<who_or_what>` is one or more users, channels or roles the rule is for.
"""
await self._remove_rule(
cog_or_cmd=cog_or_command, model_id=who_or_what.id, guild_id=ctx.guild.id
)
for w in who_or_what:
await self._remove_rule(
cog_or_cmd=cog_or_command, model_id=w.id, guild_id=ctx.guild.id
)
await ctx.send(_("Rule removed."))
@commands.guild_only()