mirror of
https://github.com/Cog-Creators/Red-DiscordBot.git
synced 2025-11-22 02:37:57 -05:00
[Audio] Improve Lavalink download/connection exception handling (#2764)
- More errors will be logged to the console with clearer messages when something goes wrong - Downloading the Lavalink Jar will abort after 5 failed attempts. The connect task will also abort if an unhandled exception occurs whilst downloading or connecting to Lavalink. After this occurs, instead of responding "Connection to Lavalink has not yet been established" to commands, the bot will respond "Connection to Lavalink has failed". This has no effect on other commands which don't involve connecting to Lavalink (e.g. settings commands). - Logs this message when Lavalink jar is successfully downloaded: `Successfully downloaded Lavalink.jar (<x> bytes written)` - Uses [`tqdm`](https://github.com/tqdm/tqdm/) to display a progress bar whilst downloading Lavalink.jar. Signed-off-by: Toby Harradine <tobyharradine@gmail.com>
This commit is contained in:
33
redbot/cogs/audio/errors.py
Normal file
33
redbot/cogs/audio/errors.py
Normal file
@@ -0,0 +1,33 @@
|
||||
import aiohttp
|
||||
|
||||
|
||||
class AudioError(Exception):
|
||||
"""Base exception for errors in the Audio cog."""
|
||||
|
||||
|
||||
class LavalinkDownloadFailed(AudioError, RuntimeError):
|
||||
"""Downloading the Lavalink jar failed.
|
||||
|
||||
Attributes
|
||||
----------
|
||||
response : aiohttp.ClientResponse
|
||||
The response from the server to the failed GET request.
|
||||
should_retry : bool
|
||||
Whether or not the Audio cog should retry downloading the jar.
|
||||
|
||||
"""
|
||||
|
||||
def __init__(self, *args, response: aiohttp.ClientResponse, should_retry: bool = False):
|
||||
super().__init__(*args)
|
||||
self.response = response
|
||||
self.should_retry = should_retry
|
||||
|
||||
def __repr__(self) -> str:
|
||||
str_args = [*map(str, self.args), self._response_repr()]
|
||||
return f"LavalinkDownloadFailed({', '.join(str_args)}"
|
||||
|
||||
def __str__(self) -> str:
|
||||
return f"{super().__str__()} {self._response_repr()}"
|
||||
|
||||
def _response_repr(self) -> str:
|
||||
return f"[{self.response.status} {self.response.reason}]"
|
||||
Reference in New Issue
Block a user